data_logger: early update earliest_block
#678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
JordanYates
force-pushed
the
bugfix/data_logger_write
branch
from
c37c660 to
781bd99
Compare
Disable the system workqueue warnings in tests. It is normally easiest to log from the system workqueue in tests, and the warning just clutters the test output. Signed-off-by: Jordan Yates <[email protected]>
Update the value of `earliest_block` before we start erasing, so that any queries to the logger state while erasing do not get an incorrect view on what blocks are available. Signed-off-by: Jordan Yates <[email protected]>
JordanYates
force-pushed
the
bugfix/data_logger_write
branch
from
781bd99 to
dd43454
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the value of
earliest_blockbefore we start erasing, so that any queries to the logger state while erasing do not get an incorrect view on what blocks are available.