lib: nrf_modem_monitor: convert to generic interface #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Move the `nrf_modem_lib` folder to a subfolder under the new `modem_monitor`. Signed-off-by: Jordan Yates <[email protected]>
JordanYates
force-pushed
the
feature/nrf_modem_monitor_generic
branch
5 times, most recently
from
80e008b to
dedb079
Compare
Remove the dependency on the nRF specific LTE header. Signed-off-by: Jordan Yates <[email protected]>
Make `nrf_modem_monitor` the generic interface for all modem monitors. Signed-off-by: Jordan Yates <[email protected]>
Drop the `_NRF_` infix for Kconfig options that are not nRF specific. Signed-off-by: Jordan Yates <[email protected]>
Extract the connectivity watchdog from `nrf_modem_monitor` to the a generic modem monitor file. Signed-off-by: Jordan Yates <[email protected]>
Fix minor SonarQube issues. Signed-off-by: Jordan Yates <[email protected]>
JordanYates
force-pushed
the
feature/nrf_modem_monitor_generic
branch
from
dedb079 to
de92d65
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the
nrf_modem_monitorinterface to a generic library that doesn't depend on Nordic headers and can be used with other LTE backends, primarily the Zephyr Cellular Modem API.