rpc: commands: unaligned data pull #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a variant of `rpc_server_pull_data` that does not expect the provided data offset to be word-aligned. This can be required for commands where the offset is an index, not a memory offset. Signed-off-by: Jordan Yates <[email protected]>
Add the option for `data_receiver` to accept unaligned input data for testing purposes. Signed-off-by: Jordan Yates <[email protected]>
Test pulling unaligned data through `rpc_server_pull_data_unaligned`. Signed-off-by: Jordan Yates <[email protected]>
JordanYates
force-pushed
the
feature/unaligned_rpc_data
branch
from
4b4b32e to
80dc014
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Fix data buffers never being freed by two commands if a data overrun was detected. Signed-off-by: Jordan Yates <[email protected]>
Repeat error tests multiple times to ensure that data buffers are freed correctly under all code paths. Signed-off-by: Jordan Yates <[email protected]>
JordanYates
force-pushed
the
feature/unaligned_rpc_data
branch
from
f62562d to
6fe78dd
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a variant of
rpc_server_pull_datathat does not expect the provided data offset to be word-aligned. This can be required for commands where the offset is an index, not a memory offset.