tdf: parse: add const qualifier to data buffer
#701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `sdk-nrf` module to fix an outdated Kconfig dependency for the system heap in the PDN library. Signed-off-by: Jordan Yates <[email protected]>
Add the `const` qualifier to the data buffer provided to the TDF parse functionality. While the `net_buf_simple` object does not use `const`, the subset of functions the library calls are all read-only on the pointer. Signed-off-by: Jordan Yates <[email protected]>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
constqualifier to the data buffer provided to the TDF parse functionality. While thenet_buf_simpleobject does not useconst, the subset of functions the library calls are all read-only on the pointer.