tools: cloud: fix return code handling for create #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix using an incorrect return code to check if a create operation succeeds. This caused the scripts to crash when attempting to create an organisation by attempting to read the response message on success. Changed return code 200 to 201 to match the api docs. Signed-off-by: Aeyohan Furtado <[email protected]>
|
Also for issues, should we be using github issues or jira (or either depending on the type of issue) |
JordanYates
approved these changes
Nov 22, 2024
If it needs an issue rather than just an immediate fix, jira for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix using an incorrect return code to check if a create operation succeeds.
This caused the scripts to crash when attempting to create an organisation by attempting to read the response message on success. Changed return code 200 to 201 to match the api docs.