socket_comms: subclasses #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limit the parallelism and fail fast so that if there is an issue that affects every combination we don't waste our precious Github actions minutes. Signed-off-by: Jordan Yates <[email protected]>
The thread may be executed at a slightly lower rate in CI. Signed-off-by: Jordan Yates <[email protected]>
Add dedicated request subclasses to reduce the amount of optional parameter checking that needs to be done to satisfy the type checker. Signed-off-by: Jordan Yates <[email protected]>
Add dedicated notification subclasses to reduce the amount of optional parameter checking that needs to be done to satisfy the type checker. Signed-off-by: Jordan Yates <[email protected]>
Add more type fixes identified by `mypy`. Signed-off-by: Jordan Yates <[email protected]>
JordanYates
force-pushed
the
feature/comms_subclasses
branch
from
6554e6c to
9fc22ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use dedicated subclasses for the various events and requests.