tools: rpc: extract handling to common file #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the option to create a connection through a context manager. Signed-off-by: Jordan Yates <[email protected]>
Use the `LocalClient` connection context over self managing the connection. Signed-off-by: Jordan Yates <[email protected]>
Use the `LocalClient` connection context over self managing the connection. Signed-off-by: Jordan Yates <[email protected]>
Extract the RPC packet handling to a common file. Signed-off-by: Jordan Yates <[email protected]>
Remove the requirement for a `InfuseRpcCommand` on client init. These changes make it easier for scripts to use the library. Signed-off-by: Jordan Yates <[email protected]>
Don't return early if `self.receive` returns NULL. Signed-off-by: Jordan Yates <[email protected]>
Automatically increment the request ID on each command run. Signed-off-by: Jordan Yates <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the RPC packet handling to a common file.