socket_comms: don't bind to IP on windows client #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the port number of the `localhost` server configurable in case the default `8080` port is already in use. Signed-off-by: Jordan Yates <[email protected]>
Support provisioning the other STM32L4 part variants. Signed-off-by: Jordan Yates <[email protected]>
Specifying the multicast groups IP address on Windows results in OSError's. Specifying only the port is sufficient. Signed-off-by: Jordan Yates <[email protected]>
Support using an externally defined termination signal instead of a per-thread signal. This allows multiple threads to be terminated in a single call. Signed-off-by: Jordan Yates <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying the multicast groups IP address on Windows results in OSError's. Specifying only the port is sufficient.