Fix exception/error state when using static_buffer with buffer_adaptor#33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
static_bufferwasn't previously usable withbuffer_adaptorbut the changes made to allow for writablestd::arrays have made it compatible.Due to the interface differences, using
static_bufferwithbuffer_adaptorwould throw an exception (or set the error state) sincesize()reports the number of readable bytes available, unlikestd::array, where it's a capacity constant. This caused writing tostatic_bufferto fail with an out of space error.Adding
resize()allowsbuffer_adaptorto effectively advance the write cursor and use it as it would any other contiguous buffer.There's no reason to use
static_bufferwithbuffer_adaptor, but may as well fix it so it works.