Skip to content

fix: Personal Merchandising can be used without AJAX filtering #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Personal Merchandising can be used without AJAX filtering #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Model/Config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,8 +388,7 @@ public function getSearchTemplateId(Store $store = null)
*/
public function isPersonalMerchandisingActive(Store $store = null)
{
return (bool) $this->getStoreConfig('tweakwise/personal_merchandising/enabled', $store)
&& $this->isAjaxFilters($store);
return (bool) $this->getStoreConfig('tweakwise/personal_merchandising/enabled', $store);
}

/**
Expand Down
15 changes: 6 additions & 9 deletions etc/adminhtml/system.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,10 +222,7 @@
</field>
</group>
<group id="personal_merchandising" translate="label" type="text" sortOrder="55" showInDefault="1" showInWebsite="1" showInStore="1">
<depends>
<field id="tweakwise/layered/ajax_filters">1</field>
</depends>
<label>Merchandising Builder</label>
<label>Personal Merchandising</label>
<field id="enabled" translate="label" type="select" sortOrder="10" showInDefault="1" showInWebsite="1" showInStore="1">
<label>Enabled</label>
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
Expand All @@ -235,11 +232,6 @@
setting below)
</comment>
</field>
<field id="analytics_enabled" translate="label" type="select" sortOrder="10" showInDefault="1" showInWebsite="1" showInStore="1">
<label>Send analytics events to tweakwise</label>
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
<comment>Note only enable this if you don't use javascript to send productviews/search/purchases requests to tweakwise</comment>
</field>
<field id="cookie_name" translate="label,comment" type="text" sortOrder="20" showInDefault="1" showInWebsite="1" showInStore="1">
<label>Cookie name</label>
<comment>Name of cookie which holds tweakwise profile information, this is usually set in the tweakwise measure script. Or when analytics is enabled, it is done automaticly</comment>
Expand All @@ -255,6 +247,11 @@
<field id="enabled">1</field>
</depends>
</field>
<field id="analytics_enabled" translate="label" type="select" sortOrder="40" showInDefault="1" showInWebsite="1" showInStore="1">
<label>Send analytics events to Tweakwise</label>
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
<comment>Note only enable this if you don't use javascript to send productviews/search/purchases requests to tweakwise</comment>
</field>
</group>
<group id="recommendations" translate="label" type="text" sortOrder="60" showInDefault="1" showInWebsite="1" showInStore="1">
<label>Recommendations</label>
Expand Down