Skip to content

Fix: filter clear url #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: beta
Choose a base branch
from
Open

Fix: filter clear url #273

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37520f6
Merge pull request #271 from EmicoEcommerce/beta
ah-net Apr 2, 2025
46dd330
fix: filter url
ah-net Apr 23, 2025
68c7b63
Style fix
ah-net Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Model/Catalog/Layer/Url/Strategy/PathSlugStrategy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,8 @@ public function buildFilterUrl(MagentoHttpRequest $request, array $filters = [])
} else {
// Replace filter path in current URL with the new filter combination path
if (strpos($currentUrl, $currentFilterPath) !== false) {
$url = str_replace($currentFilterPath, $newFilterPath, $currentUrl);
rtrim($currentFilterPath, '/');
$url = str_replace($currentFilterPath . '/', $newFilterPath . '/', $currentUrl);
Comment on lines +398 to +399
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rtrim is currently doing nothing, because the expression result is not used anywhere.
Use this instead of the two new added lines:

$url = str_replace(
    sprintf('%s/', rtrim($currentFilterPath, '/')),
    sprintf('%s/', $newFilterPath),
    $currentUrl
);

} else {
$url = $currentUrl . '/' . $newFilterPath;
}
Expand Down
Loading