fix: hyva analytics #277
Open
fix: hyva analytics #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansentjeu
requested changes
May 3, 2025
| $profileKey = $this->config->getProfileKey(); | ||
|
|
||
| //hyva theme | ||
| if (empty($type)) { | ||
| $contentDecoded = json_decode($request->getContent(), true); |
There was a problem hiding this comment.
Use the Magento JSON serializer class instead of json_decode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tweakwise analytics is enabled. And you use the hyva theme the type and value is never set. This is because hyva sends the parameters diffrently then the luma theme. This pull request fixes that.