Skip to content

Fix remove dot profilekey #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: beta
Choose a base branch
from
Open

Fix remove dot profilekey #278

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
37520f6
Merge pull request #271 from EmicoEcommerce/beta
ah-net Apr 2, 2025
c82d6ca
fix:remove dot profile key
ah-net May 1, 2025
5e2f7f7
Use random class
ah-net May 7, 2025
d06743d
Add docblock
ah-net May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions Model/PersonalMerchandisingConfig.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,25 @@
use Magento\Framework\Stdlib\Cookie\PublicCookieMetadata;
use Magento\Store\Model\Store;
use Magento\Framework\Exception\LocalizedException;
use Magento\Framework\Math\Random;

class PersonalMerchandisingConfig extends Config
{
/**
* Constructor.
*
* @param ScopeConfigInterface $config
* @param Json $jsonSerializer
* @param RequestInterface $request
* @param State $state
* @param WriterInterface $configWriter
* @param TypeListInterface $cacheTypeList
* @param CookieManagerInterface $cookieManager
* @param CookieMetadataFactory $cookieMetadataFactory
* @param Random $mathRandom
*
* @throws LocalizedException
*/
public function __construct(
ScopeConfigInterface $config,
Json $jsonSerializer,
Expand All @@ -25,7 +41,8 @@ public function __construct(
WriterInterface $configWriter,
TypeListInterface $cacheTypeList,
private readonly CookieManagerInterface $cookieManager,
private readonly CookieMetadataFactory $cookieMetadataFactory
private readonly CookieMetadataFactory $cookieMetadataFactory,
private readonly Random $mathRandom
) {
parent::__construct($config, $jsonSerializer, $request, $state, $configWriter, $cacheTypeList);
}
Expand Down Expand Up @@ -81,6 +98,6 @@ private function getCookieMetadata(): PublicCookieMetadata
*/
private function generateProfileKey(): string
{
return uniqid('', true);
return $this->mathRandom->getUniqueHash();
}
}
Loading