Import support for Clue and Flo #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
carstenhag
requested changes
Apr 21, 2025
app/src/main/java/com/mensinator/app/settings/ExportImportDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/mensinator/app/settings/ExportImportDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/mensinator/app/settings/ExportImportDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/mensinator/app/settings/ExportImportDialog.kt
Outdated
Show resolved
Hide resolved
|
Also please include an example import json into the project. Else this is difficult to maintain or test. For now just include it in a testing folder, at some point unit tests should be written for the imports. |
|
In the linked issue I have example of exportfile from Clue and some information that is good to know: |
…ded enum. Updated strings
carstenhag
requested changes
May 2, 2025
app/src/main/java/com/mensinator/app/settings/SettingsViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/mensinator/app/business/PeriodDatabaseHelper.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/mensinator/app/settings/SettingsViewModel.kt
Outdated
Show resolved
Hide resolved
|
I think I fixed most of your comments (except the one about formatting dates). I do need to refactor the entire import/export process, not only for Mensinator. But the ViewModel should not send toast to UI, it should be done in ExportImport. But I want to do that mayor change in another PR. |
carstenhag
requested changes
May 4, 2025
app/src/main/java/com/mensinator/app/settings/SettingsViewModel.kt
Outdated
Show resolved
Hide resolved
carstenhag
changed the title
This was
linked to
issues
May 4, 2025
carstenhag
requested changes
May 8, 2025
app/src/main/java/com/mensinator/app/settings/SettingsViewModel.kt
Outdated
Show resolved
Hide resolved
carstenhag
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@carstenhag Need help with getting the file to new class ClueImport. I think the rest might work?