Generate correct view definition if a table shares its name with the database #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamors
changed the title
Contributor
|
It sounds like you did a fair bit of research on this to identify a mysql bug, etc., so I'd like to document the variations in code with a few test cases. My best idea is extracting the sanitization (normalization?) logic here into a utility method that can be tested without installing each example version of MySQL. Thoughts? |
Contributor
|
@adamors Would it be helpful if I extracted the utility method? I'm not positive what the test cases should be, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3
The regex looks for either a space, an open brace or a comma before the database name, avoiding matching substrings where the database name appears twice.