Open links banner in new tab #236
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertlluberes
requested changes
Nov 10, 2022
| { | ||
| case 1: | ||
| <a href="https://bit.ly/xam-dev"><img class="img-fluid" src="~/img/banners/megsoft-job.png" /></a> | ||
| <a href="https://bit.ly/xam-dev" target="_blank()"><img class="img-fluid" src="~/img/banners/megsoft-job.png" /></a> |
Collaborator
There was a problem hiding this comment.
Hi Junior @jsuarezwd , the target attribute should have the value _blank instead of _blank(), also I consider we should include the attribute rel with the values noopener noreferrer for security reasons. See suggested changes:
Suggested change
| <a href="https://bit.ly/xam-dev" target="_blank()"><img class="img-fluid" src="~/img/banners/megsoft-job.png" /></a> | |
| <a href="https://bit.ly/xam-dev" target="_blank" rel="noopener noreferrer"><img class="img-fluid" src="~/img/banners/megsoft-job.png" /></a> | |
Can you please apply those changes to each banner?
Source:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?