Skip to content

fix i18n for connector pop up #3977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

fix i18n for connector pop up #3977

merged 1 commit into from
May 13, 2025

Conversation

yushih
Copy link
Collaborator

@yushih yushih commented May 7, 2025

No description provided.

@yushih yushih requested a review from Nebyt May 7, 2025 04:05
@sonarqube-yoroi
Copy link

Comment on lines +100 to +102
.then(() => {
return loadedStores;
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better return after console.log on the first then?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aatsindev , thanks for reviewing! Could you please help make a commit to this branch? Thanks.

@vsubhuman vsubhuman added this to the 5.9.0 milestone May 8, 2025
@vsubhuman vsubhuman merged commit f0d1e75 into develop May 13, 2025
22 checks passed
@vsubhuman vsubhuman deleted the fix/connector-i18n branch May 13, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants