Skip to content

fix cashbak wrong wallet popup #3980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

Conversation

yushih
Copy link
Collaborator

@yushih yushih commented May 7, 2025

Fix two issues with the cashback page pop-up dialog:

  1. If the user is already on this page and the current wallet is the cashback wallet, after switching wallet, the pop-up should show.

  2. After the user confirms to switch wallet, the pop-up should disappear.

@yushih yushih requested a review from Nebyt May 7, 2025 08:54
@sonarqube-yoroi
Copy link

@vsubhuman vsubhuman added this to the 5.9.0 milestone May 8, 2025
@vsubhuman vsubhuman merged commit c5fb251 into develop May 13, 2025
12 checks passed
@vsubhuman vsubhuman deleted the fix/cashback-wrong-wallet-dialog branch May 13, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants