Skip to content

Make dRep selection more neutral and dRep-agnostic#4477

Open
Cerkoryn wants to merge 5 commits intoEmurgo:developfrom
Cerkoryn:drep-neutrality
Open

Make dRep selection more neutral and dRep-agnostic#4477
Cerkoryn wants to merge 5 commits intoEmurgo:developfrom
Cerkoryn:drep-neutrality

Conversation

@Cerkoryn
Copy link

@Cerkoryn Cerkoryn commented Mar 5, 2026

Updates mobile governance selection copy/labels to present DRep options more neutrally and support informed choice, with no changes to delegation logic or available options.


Note

Medium Risk
Changes remove Yoroi-specific delegation shortcuts and combined stake+governance delegation transactions, which can alter user flows and pending-state handling across governance and staking screens. Risk is moderate because it touches transaction-building paths and multiple screens, but does not change core signing/auth logic.

Overview
Removes Yoroi-promotional governance UI: deletes YoroiDrepCard/YoroiRecordLink, drops remote-config controlled Yoroi DRep banners, and simplifies the DRep selection modal to only prompt for an ID/handle (with new fixed modal heights).

Unifies delegation state handling to be DRep-agnostic by collapsing pending-vote tracking to a single delegate state and replacing Yoroi-vs-other branching (isDelegatingToYoroiDrep, delegate-yoroi/delegate-other) with generic isDelegatingToDrep/drepDisplayId across Home, VotingOptions, and ChangeVote.

Removes the "Earn Rewards" banner feature and its staking+governance combined-delegation helper, and updates StakingCenter so pool delegation always builds a stake-only tx; the governance-required modal now routes users to governance options instead of delegating to a preset Yoroi DRep, with corresponding i18n string cleanup.

Written by Cursor Bugbot for commit f5edbcf. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant