Make dRep selection more neutral and dRep-agnostic#4477
Open
Cerkoryn wants to merge 5 commits intoEmurgo:developfrom
Open
Make dRep selection more neutral and dRep-agnostic#4477Cerkoryn wants to merge 5 commits intoEmurgo:developfrom
Cerkoryn wants to merge 5 commits intoEmurgo:developfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates mobile governance selection copy/labels to present DRep options more neutrally and support informed choice, with no changes to delegation logic or available options.
Note
Medium Risk
Changes remove Yoroi-specific delegation shortcuts and combined stake+governance delegation transactions, which can alter user flows and pending-state handling across governance and staking screens. Risk is moderate because it touches transaction-building paths and multiple screens, but does not change core signing/auth logic.
Overview
Removes Yoroi-promotional governance UI: deletes
YoroiDrepCard/YoroiRecordLink, drops remote-config controlled Yoroi DRep banners, and simplifies the DRep selection modal to only prompt for an ID/handle (with new fixed modal heights).Unifies delegation state handling to be DRep-agnostic by collapsing pending-vote tracking to a single
delegatestate and replacing Yoroi-vs-other branching (isDelegatingToYoroiDrep,delegate-yoroi/delegate-other) with genericisDelegatingToDrep/drepDisplayIdacrossHome,VotingOptions, andChangeVote.Removes the "Earn Rewards" banner feature and its staking+governance combined-delegation helper, and updates
StakingCenterso pool delegation always builds a stake-only tx; the governance-required modal now routes users to governance options instead of delegating to a preset Yoroi DRep, with corresponding i18n string cleanup.Written by Cursor Bugbot for commit f5edbcf. This will update automatically on new commits. Configure here.