feat: draw the tracked hand skeleton over the camera - #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Answers the only question the UI could not: is it seeing me?
Until now, a hand that was tracked but whose shape was unknown looked exactly like a hand that was never detected — both produced silence. The user had no way to tell whether to move closer, fix the light, or change the handshape.
Three states, because "nothing happened" has three causes
cover→containThe video was cropping its sides, so a hand could be detected outside the visible area — the overlay would have drawn a skeleton onto a hand the user could not see. With
contain, what you see is exactly what the model gets. The overlay projects landmarks through the same letterboxing, so the skeleton lands on the hand rather than near it.MediaPipe 1.0.1
Also in this branch, superseding #2. Verified locally before merging rather than trusted: typecheck, build and all 43 tests pass, and the WASM filenames
FilesetResolverlooks for are unchanged across the major. That last one matters becausescripts/copy-wasm.mjsstages the runtime fromnode_modules— the bump moves the JS and the WASM together, which is exactly why the WASM is not committed.Camera still unverified under WSL2 (no device access); the projection maths is geometry, not something the synthetic-hand tests can exercise.