feat: let the user download and free the cached engine - #14
Closed
Endika wants to merge 14 commits into
Closed
Conversation
Bumps the train-minor-and-patch group in /tools/train with 6 updates: | Package | From | To | | --- | --- | --- | | [torch](https://github.com/pytorch/pytorch) | `2.9.1` | `2.13.0` | | [numpy](https://github.com/numpy/numpy) | `2.3.4` | `2.5.1` | | [onnx](https://github.com/onnx/onnx) | `1.19.1` | `1.22.0` | | [onnxruntime](https://github.com/microsoft/onnxruntime) | `1.23.2` | `1.28.0` | | [scikit-learn](https://github.com/scikit-learn/scikit-learn) | `1.7.2` | `1.9.0` | | [tqdm](https://github.com/tqdm/tqdm) | `4.67.1` | `4.70.0` | Updates `torch` from 2.9.1 to 2.13.0 - [Release notes](https://github.com/pytorch/pytorch/releases) - [Changelog](https://github.com/pytorch/pytorch/blob/main/RELEASE.md) - [Commits](pytorch/pytorch@v2.9.1...v2.13.0) Updates `numpy` from 2.3.4 to 2.5.1 - [Release notes](https://github.com/numpy/numpy/releases) - [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst) - [Commits](numpy/numpy@v2.3.4...v2.5.1) Updates `onnx` from 1.19.1 to 1.22.0 - [Release notes](https://github.com/onnx/onnx/releases) - [Changelog](https://github.com/onnx/onnx/blob/main/docs/Changelog-ml.md) - [Commits](onnx/onnx@v1.19.1...v1.22.0) Updates `onnxruntime` from 1.23.2 to 1.28.0 - [Release notes](https://github.com/microsoft/onnxruntime/releases) - [Changelog](https://github.com/microsoft/onnxruntime/blob/main/docs/ReleaseManagement.md) - [Commits](microsoft/onnxruntime@v1.23.2...v1.28.0) Updates `scikit-learn` from 1.7.2 to 1.9.0 - [Release notes](https://github.com/scikit-learn/scikit-learn/releases) - [Commits](scikit-learn/scikit-learn@1.7.2...1.9.0) Updates `tqdm` from 4.67.1 to 4.70.0 - [Release notes](https://github.com/tqdm/tqdm/releases) - [Commits](tqdm/tqdm@v4.67.1...v4.70.0) --- updated-dependencies: - dependency-name: torch dependency-version: 2.13.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: train-minor-and-patch - dependency-name: numpy dependency-version: 2.5.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: train-minor-and-patch - dependency-name: onnx dependency-version: 1.22.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: train-minor-and-patch - dependency-name: onnxruntime dependency-version: 1.28.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: train-minor-and-patch - dependency-name: scikit-learn dependency-version: 1.9.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: train-minor-and-patch - dependency-name: tqdm dependency-version: 4.70.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: train-minor-and-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [pandas](https://github.com/pandas-dev/pandas) from 2.3.4 to 3.0.5. - [Release notes](https://github.com/pandas-dev/pandas/releases) - [Commits](https://github.com/pandas-dev/pandas/commits/v3.0.5) --- updated-dependencies: - dependency-name: pandas dependency-version: 3.0.5 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 4 to 5. - [Release notes](https://github.com/actions/dependency-review-action/releases) - [Commits](actions/dependency-review-action@v4...v5) --- updated-dependencies: - dependency-name: actions/dependency-review-action dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@commitlint/config-conventional](https://github.com/conventional-changelog/commitlint/tree/HEAD/@commitlint/config-conventional) from 20.5.3 to 21.2.0. - [Release notes](https://github.com/conventional-changelog/commitlint/releases) - [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/@commitlint/config-conventional/CHANGELOG.md) - [Commits](https://github.com/conventional-changelog/commitlint/commits/v21.2.0/@commitlint/config-conventional) --- updated-dependencies: - dependency-name: "@commitlint/config-conventional" dependency-version: 21.2.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@commitlint/cli](https://github.com/conventional-changelog/commitlint/tree/HEAD/@commitlint/cli) from 20.5.3 to 21.2.1. - [Release notes](https://github.com/conventional-changelog/commitlint/releases) - [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/@commitlint/cli/CHANGELOG.md) - [Commits](https://github.com/conventional-changelog/commitlint/commits/v21.2.1/@commitlint/cli) --- updated-dependencies: - dependency-name: "@commitlint/cli" dependency-version: 21.2.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine is ~29 MB of WASM and weights, cached on first use. Taking that much of a phone's storage without asking, and with no way to get it back, is not a reasonable default.
MediaPipeLandmarkSource.load(), which downloads exactly the WASM variant this browser will use; guessing would have fetched both the SIMD and no-SIMD builds and wasted 11 MB.esku-enginecache. It re-downloads next time the camera starts.Content-Lengthrather than by reading 11 MB of WASM into memory to weigh it.Taught signs are deliberately untouched. They are the user's own recordings, they live in IndexedDB, and wiring them into a "free up space" button would be a data-loss trap. Said so in the panel too.
Worth recording: this came from a question about the app downloading "3 GB". It does not — the 3.5 GB is the SWL-LSE training dataset, which is downloaded once to train the model and never shipped. The user only ever fetches ~29 MB. The confusion was still worth acting on.