ci(release): stop release-please auto-merge loop - #325
Closed
Endika wants to merge 1 commit into
Closed
Conversation
The release job deleted the release branch and re-dispatched itself when the PR had not merged within 60s. Because the PR was authored by GITHUB_TOKEN its CI never ran (action_required), so it never went green, auto-merge never fired, and the branch-delete + self-redispatch recreated the release PR every ~90s indefinitely. Mirror the working sister-app config: author the PR with RELEASE_PLEASE_TOKEN so CI runs on it, then just enable native auto-merge. The PAT-authored merge is a push to main that re-triggers this workflow to cut the release and the on:push deploy, so the delete/redispatch and explicit deploy dispatch are no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Release Pleasewas stuck in an infinite loop, re-dispatching itself every ~90s and recreating thechore(main): release 1.7.5PR (churned #295 → #324+). Release 1.7.5 never landed; latest published stayed at v1.7.4.Root causes
gh workflow run $WORKFLOW(self-redispatch) whenever the PR had not merged within its 60s wait loop.GITHUB_TOKEN, so its CI never ran (action_required) → never green → native auto-merge never fired → the delete + redispatch recreated the PR forever.Fix
Align with the working sister-app config (Monete):
RELEASE_PLEASE_TOKEN(PAT) so CI runs on it and can go green.gh pr merge --rebase --auto). The PAT-authored merge is a push tomainthat re-triggers this workflow to cut the release and theon: pushdeploy.actions: writepermission.Required before this works (manual, cannot be done from here)
RELEASE_PLEASE_TOKEN(a PAT withrepo+workflowscope), as in the sister apps.gh workflow enable "Release Please" --repo Endika/influence-sensor.release-please--branches--main--...PRs/branches left by the loop.