Added a slash command for swizzleimage - #176
Open
warp-core wants to merge 2 commits into
Open
Conversation
Because we can't include attachments with slash commands, the slash command version of swizzleimage will expect the images to swizzle to be attached to the last message sent before the command was sent, that message will also need to be from the same user as the slash command. There's a bunch of repeated code here for each version of the command that could be combined (doing so would slightly change the way the current version of the command works but not hugely) but I'd like comments on this implementation before doing that refactor, also, since the non-slash commands are being deprecated, it might be better to just wipe the old code when that happens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because we can't include attachments with slash commands, the slash command version of swizzleimage will expect the images to swizzle to be attached to the last message sent before the command was sent, that message will also need to be from the same user as the slash command.
There's a bunch of repeated code here for each version of the command that could be combined (doing so would slightly change the way the current version of the command works but not hugely) but I'd like comments on this implementation before doing that refactor, also, since the non-slash commands are being deprecated, it might be better to just wipe the old code when that happens.