Fix pistons breaking when head is replaced - #3011
Draft
VanJackal wants to merge 1 commit into
Draft
Conversation
Member
|
Thank you for looking into this! 😀 I can't investigate or review too deeply right now as I'm just replying on my lunch break, but from memory the entire "dirty" / update process here should be gated by a "changed check" coming from MC itself further up, unless something has changed within MC. Either way if that check itself no longer functions, it should be fixed at the top level rather than in here. There are niche situations where we want to force these to occur always (eg, //update command), and it's not the only change that should be skipped during a no-op change during typical edits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2956 by adding a check for if the block was changed before calling
affectNeighborsAfterRemoval