Skip to content

Improve seq_region_matches function - now uses core db look-up rather than file parse #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ainefairbrother wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve seq_region_matches function - now uses core db look-up rather than file parse #35

ainefairbrother wants to merge 2 commits into from

Conversation

@ainefairbrother
Copy link
Contributor

@ainefairbrother ainefairbrother commented Jul 4, 2025 •
edited
Loading

Main changes:

  • From L531 - use Ensembl core db look-up instead of VCF parse
  • From L807 - add back in the check to see if EVA and Ensembl have any matching seq regions & warn if not

The rest of the changes are ruff formatting.

@ainefairbrother ainefairbrother requested a review from nakib103 July 4, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nakib103 nakib103 Awaiting requested review from nakib103

Assignees

No one assigned

Labels

on hold

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ainefairbrother @nakib103