Skip to content

Disha/subworkflow test#37

Open
Dishalodha wants to merge 14 commits into
mainfrom
disha/subworkflow_test
Open

Disha/subworkflow test#37
Dishalodha wants to merge 14 commits into
mainfrom
disha/subworkflow_test

Conversation

@Dishalodha
Copy link
Copy Markdown
Collaborator

@Dishalodha Dishalodha commented May 6, 2026

Here I have

  1. Corrected the sub-workflow test to not rely on the copied files and pass the ci test.
  2. Updated the nf-test version as the tests were failing with the old version.
  3. Updated the url module as the tests were failing because the env couldn't recognise the defined variables.

PS: nf-linting still needs correction.


stub:
def prefix = task.ext.prefix ?: "${meta.accession}"
def accession = meta.accession ?: meta.id ?: "stub"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if this value should not be passed as meta.id from somewhere else for the testing?

Comment thread modules/ensembl/urls/extract/main.nf
Comment thread modules/ensembl/urls/generate/main.nf Outdated
Comment thread subworkflows/ensembl/prepare_genome_metadata/meta.yml
Dishalodha and others added 2 commits May 6, 2026 16:26
Co-authored-by: Jorge Alvarez-Jarreta <jalvarez@ebi.ac.uk>
Removing dependency on meta_id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants