Phase 3: Consolidate duplication in vector-store and tools#158
Merged
gvonness-apolitical merged 2 commits intomainfrom Mar 13, 2026
Merged
Phase 3: Consolidate duplication in vector-store and tools#158gvonness-apolitical merged 2 commits intomainfrom
gvonness-apolitical merged 2 commits intomainfrom
Conversation
Consolidate ~80 lines of duplicated cleanup logic from cleanupExpired() and evictOldest() into a shared private method that handles chunk deletion, empty cluster removal, orphaned index entry cleanup, and memory state sync.
- recordRetrievalSafe: replaces 3 identical try/catch blocks around recordRetrieval() in search, recall, and predict handlers - extractRetrievalArgs: replaces repetitive arg extraction (query, project, agent, maxTokens) across the same 3 handlers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
removeVectorsAndRelated()— consolidates ~80 lines of duplicated cleanup logic fromcleanupExpired()andevictOldest()into a shared private methodrecordRetrievalSafe()— replaces 3 identical try/catch blocks in search/recall/predict handlersextractRetrievalArgs()— replaces repetitive arg extraction across the same 3 handlersNet: -53 lines, zero behavior change.
Test plan
npm run build:serverpassesnpm test— 2559 tests pass (121 files)npm run lint— 0 errors, 0 warningsnpm run format:check— all files compliant