Phase 4a: Break searchContext and ingestSession into pipeline stages#159
Merged
gvonness-apolitical merged 2 commits intomainfrom Mar 13, 2026
Merged
Phase 4a: Break searchContext and ingestSession into pipeline stages#159gvonness-apolitical merged 2 commits intomainfrom
gvonness-apolitical merged 2 commits intomainfrom
Conversation
Extract 6 functions from the monolithic searchContext: - filterByAgent: eliminates 4x duplicated agent post-filtering - applyEntityBoost: shared entity boost RRF fusion - keywordPrimarySearch: keyword-first retrieval path - indexBasedSearch: hybrid retrieval via semantic index - chunkBasedSearch: hybrid fallback via chunk vectors - postProcessResults: shared post-processing pipeline searchContext is now a clear orchestrator: pick path → fuse → post-process.
Extract 3 stage functions from the monolithic ingestSession: - validateAndSetup: session info, checkpoints, mtime, skip checks - assembleSessionTurns: stream/file parsing, incremental filtering - initializeEmbedding: embedder setup with error recovery Sub-agent processing kept inline (complex team topology branching).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
searchContextfrom 440-line monolith into 6 extracted stage functions + 120-line orchestrator. Eliminates 4x agent post-filtering duplication and 2x entity boost duplication.ingestSessionfrom 370-line monolith into 3 composable stages + simplified orchestrator. Sub-agent processing kept inline (complex team branching).Zero behavior change — pure structural refactoring.
Test plan
npm run build:serverpassesnpm test— 2559 tests pass (121 files)npm run lint— 0 errors, 0 warningsnpm run format:check— all files compliant