Phase 4b: Table-drive config and extract VectorStore cleanup#160
Merged
gvonness-apolitical merged 2 commits intomainfrom Mar 13, 2026
Merged
Phase 4b: Table-drive config and extract VectorStore cleanup#160gvonness-apolitical merged 2 commits intomainfrom
gvonness-apolitical merged 2 commits intomainfrom
Conversation
Replace ~230 lines of repetitive field-by-field boilerplate with declarative ENV_MAPPINGS (29 entries) and CONFIG_MAPPINGS (26 entries) tables plus generic applicator functions. Tables serve as self- documenting config mapping reference.
Move DB cleanup logic (removeVectorsAndRelated, findExpiredVectorIds, findOldestVectorIds) to vector-store-cleanup.ts. VectorStore class reduced from 733 to 665 lines. Public API unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadEnvConfig()andtoRuntimeConfig()with declarative mapping tables (ENV_MAPPINGS,CONFIG_MAPPINGS) and generic applicators. Tables serve as self-documenting config reference.removeVectorsAndRelated,findExpiredVectorIds,findOldestVectorIds) into a standalone module. VectorStore class reduced from 733 → 665 lines. Public API unchanged.Test plan
npm run build:serverpassesnpm test— 2559 tests pass (121 files)npm run lint— 0 errors, 0 warningsnpm run format:check— all files compliant