Codebase cleanup: schema fixes, CI validation, and documentation improvements#14
Merged
gvonness-apolitical merged 1 commit intomainfrom Feb 1, 2026
Merged
Conversation
Schema fixes: - Add missing allOf conditions for horizontalRule and break block types - Fix tableCell children to require blocks only (not textNode), resolving oneOf ambiguity - Fix cross-schema references to use full URLs instead of relative paths CI/CD: - Add GitHub Action for automated schema and example validation - Handle cross-schema references with -r flag for annotations and phantoms schemas Documentation: - Create comprehensive example document demonstrating all block types - Update spec to reflect tableCell block-only children requirement - Add tableCell content rule and update examples in spec - Update Editors field in introduction - Add strategic insights summary to design-decisions.md - Archive strategy conversation notes to docs/archive/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allOfconditions forhorizontalRuleandbreakblock types; fixtableCellchildren to require blocks only (resolving oneOf validation ambiguity); fix cross-schema references to use full URLsDetails
Schema Fixes
horizontalRule/break validation (
content.schema.json): These block types were defined in$defsbut missing from theallOfconditional chain, causing documents using them to not validate correctly.tableCell children ambiguity (
content.schema.json): TheoneOf: [textNode, block]pattern was ambiguous because both schemas have atypefield. Changed to block-only (consistent withlistItem). Updated spec documentation and examples accordingly.Cross-schema references (
annotations.schema.json,phantoms.schema.json): Changed relative references likeanchor.schema.json#/$defs/contentAnchorto full URLshttps://codex.document/schemas/anchor.schema.json#/$defs/contentAnchorfor proper JSON Schema resolution.CI/CD
New GitHub Action (
.github/workflows/validate-schemas.yml) that:Documentation
examples/comprehensive-document/demonstrating all block types including horizontalRule, break, definitionList, measurement, signature, svg, barcode, and figurespec/core/03-content-blocks.mdwith tableCell block-only requirement and fixed all table examplesdocs/design-decisions.mddocs/archive/Test plan