Skip to content

add diff rule for chlo.square#2426

Merged
mofeing merged 13 commits into
mainfrom
ss/diff-chlo-square
May 12, 2026
Merged

add diff rule for chlo.square#2426
mofeing merged 13 commits into
mainfrom
ss/diff-chlo-square

Conversation

@mofeing
Copy link
Copy Markdown
Collaborator

@mofeing mofeing commented Apr 14, 2026

closes #2404

cc @joelberkeley

@Pangoraw
Copy link
Copy Markdown
Collaborator

Can you add a test with complex numbers?

https://openxla.org/stablehlo/generated/chlo#chlosquare_chlosquareop

@mofeing
Copy link
Copy Markdown
Collaborator Author

mofeing commented Apr 15, 2026

while testing the complex version of this, I found out that diff rules that use HloConstantOp are broken for complex numbers.

waiting for EnzymeAD/Enzyme#2790 to be merged to continue on this.

@mofeing mofeing force-pushed the ss/diff-chlo-square branch from 4d2df8f to 39c4014 Compare May 10, 2026 23:01
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.47%. Comparing base (e32b005) to head (8829a88).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2426      +/-   ##
==========================================
+ Coverage   24.99%   25.47%   +0.48%     
==========================================
  Files         220      220              
  Lines       44574    44600      +26     
==========================================
+ Hits        11141    11364     +223     
+ Misses      33433    33236     -197     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mofeing mofeing merged commit 60b6da4 into main May 12, 2026
28 of 31 checks passed
@mofeing mofeing deleted the ss/diff-chlo-square branch May 12, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Derivative of CHLO square

2 participants