Suggestion: remove code-suggester, print diff instead#2312
Closed
danielwe wants to merge 1 commit intoEnzymeAD:mainfrom
Closed
Suggestion: remove code-suggester, print diff instead#2312danielwe wants to merge 1 commit intoEnzymeAD:mainfrom
danielwe wants to merge 1 commit intoEnzymeAD:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2312 +/- ##
==========================================
+ Coverage 67.50% 75.46% +7.96%
==========================================
Files 31 56 +25
Lines 12668 16738 +4070
==========================================
+ Hits 8552 12632 +4080
+ Misses 4116 4106 -10 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
To bolster the case, #2301 is also full of nonsense suggestions such as #2301 (comment) |
Member
|
Thanks, take a look at #2313 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to creating rather noisy PR threads, code-suggester is fundamentally broken as evidenced by all the nonsense suggestions in #1852. Google does not intend to fix this as explained here: googleapis/code-suggester#505 (comment).
So I thought it might be better to skip the suggestions and simply let the CI action pass/fail depending on whether the PR is compliant. Runic's suggested diff can then be found in the CI logs.