Conversation
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/src/jlrt.jl b/src/jlrt.jl
index bd622e0..503360d 100644
--- a/src/jlrt.jl
+++ b/src/jlrt.jl
@@ -366,9 +366,9 @@ function val_from_byref_if_mixed(B::LLVM.IRBuilder, gutils::GradientUtils, @nosp
end
end
-@generated function ref_if_mixed(val::VT) where VT
- areg = active_reg_inner(VT, (), nothing, Val(true))
- if areg == ActiveState || areg == MixedState
+@generated function ref_if_mixed(val::VT) where {VT}
+ areg = active_reg_inner(VT, (), nothing, Val(true))
+ return if areg == ActiveState || areg == MixedState
quote
Base.@_inline_meta
Ref(val)
@@ -390,10 +390,10 @@ function byref_from_val_if_mixed(B::LLVM.IRBuilder, @nospecialize(val::LLVM.Valu
if legal && act == AnyState
return val
end
- return emit_apply_generic!(B, LLVM.Value[unsafe_to_llvm(B, ref_if_mixed), val])
+ return emit_apply_generic!(B, LLVM.Value[unsafe_to_llvm(B, ref_if_mixed), val])
end
act = active_reg_inner(TT, (), world)
-
+
if act == ActiveState || act == MixedState
obj = emit_allocobj!(B, Base.RefValue{TT})
lty = convert(LLVMType, TT) |
Contributor
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Joe's issue