Skip to content

Handle recursive store for primitive types symbol/string#2342

Merged
wsmoses merged 1 commit intomainfrom
recstr
Apr 18, 2025
Merged

Handle recursive store for primitive types symbol/string#2342
wsmoses merged 1 commit intomainfrom
recstr

Conversation

@wsmoses
Copy link
Member

@wsmoses wsmoses commented Mar 28, 2025

No description provided.

@github-actions
Copy link
Contributor

Benchmark Results

main ffa3f27... main/ffa3f27a7aa63c...
basics/overhead 4.34 ± 0.002 ns 4.34 ± 0.002 ns 1
time_to_load 1.1 ± 0.0019 s 1.09 ± 0.0028 s 1.01

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@vchuravy
Copy link
Member

Is this the same as #2263

@wsmoses
Copy link
Member Author

wsmoses commented Apr 1, 2025

your fix might be more general, but also not completely solve the issue. Essentially from here we have this fallback case if we know the object is a jl_valuet and we just put a null pointer there. Here we hardcode adding string/symbol (but ensuring we actually do the null store), whereas yours has a more general 0 check but doesn't store (potentially still having the GC issue)

@vchuravy
Copy link
Member

vchuravy commented Apr 9, 2025

So we should likely do both? Aka it makes no sense to try and store into a datatype without any fields, but we should also create a shadow store for those objects.

@vchuravy
Copy link
Member

vchuravy commented Apr 9, 2025

Check #2263?

@wsmoses
Copy link
Member Author

wsmoses commented Apr 18, 2025

@vchuravy we should discuss this next week. going to merge to unblock flux test infra

@wsmoses wsmoses merged commit d3e0e40 into main Apr 18, 2025
26 of 31 checks passed
@vchuravy vchuravy deleted the recstr branch April 20, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants