Closed
Conversation
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/src/compiler.jl b/src/compiler.jl
index 82a11400..24e45a4c 100644
--- a/src/compiler.jl
+++ b/src/compiler.jl
@@ -4375,9 +4375,9 @@ function GPUCompiler.compile_unhooked(output::Symbol, job::CompilerJob{<:EnzymeT
permit_inlining!(f)
end
- LLVM.@dispose pb=LLVM.NewPMPassBuilder() begin
+ LLVM.@dispose pb = LLVM.NewPMPassBuilder() begin
@ccall libEnzyme.registerEnzymeAndPassPipeline(pb::Ptr{Cvoid}, 0::UInt8)::Cvoid
-
+
LLVM.add!(pb, LLVM.NewPMModulePassManager()) do mpm
LLVM.add!(mpm, PreserveNVVMPass(true))
end
diff --git a/src/compiler/optimize.jl b/src/compiler/optimize.jl
index d966d087..046bd4b7 100644
--- a/src/compiler/optimize.jl
+++ b/src/compiler/optimize.jl
@@ -66,7 +66,7 @@ function run_jl_pipeline(pm::ModulePassManager, tm::LLVM.TargetMachine; kwargs..
end
return true
end
- add!(pm, NewPMModulePass("JLPipeline", jl_pipeline))
+ return add!(pm, NewPMModulePass("JLPipeline", jl_pipeline))
end
@static if VERSION < v"1.11.0-DEV.428"
@@ -365,7 +365,7 @@ else
end
return true
end
- add!(pm, NewPMModulePass("CombineMulAdd", combine_mul_add))
+ add!(pm, NewPMModulePass("CombineMulAdd", combine_mul_add))
end
end
end |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #2475 +/- ##
===========================================
- Coverage 75.16% 30.23% -44.94%
===========================================
Files 57 2 -55
Lines 17821 215 -17606
===========================================
- Hits 13395 65 -13330
+ Misses 4426 150 -4276 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2e6039d to
2d70da2
Compare
wsmoses
reviewed
Sep 29, 2025
| end | ||
|
|
||
| LLVM.ModulePassManager() do pm | ||
| LLVM.@dispose pb=LLVM.NewPMPassBuilder() begin |
Member
There was a problem hiding this comment.
Let's start to begin with just the preservenvvm being moved over (and leave the others the same, to confirm)
Member
|
replaced by #2675 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.