Skip to content

add support for ignore_derivatives#2547

Merged
vchuravy merged 1 commit intomainfrom
vc/ignore_derivatives
Sep 26, 2025
Merged

add support for ignore_derivatives#2547
vchuravy merged 1 commit intomainfrom
vc/ignore_derivatives

Conversation

@vchuravy
Copy link
Member

@vchuravy vchuravy commented Sep 1, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025

Benchmark Results

main ca95f5a... main / ca95f5a...
basics/overhead 5.25 ± 0.01 ns 4.34 ± 0.051 ns 1.21 ± 0.014
time_to_load 1.3 ± 0.012 s 1.28 ± 0.0083 s 1.01 ± 0.012

Benchmark Plots

A plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/17383306519/artifacts/3900042447.

@codecov
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

❌ Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.36%. Comparing base (83984b0) to head (df5ed81).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
lib/EnzymeCore/src/EnzymeCore.jl 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2547      +/-   ##
==========================================
+ Coverage   74.33%   74.36%   +0.03%     
==========================================
  Files          57       57              
  Lines       17960    17985      +25     
==========================================
+ Hits        13351    13375      +24     
- Misses       4609     4610       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vchuravy vchuravy marked this pull request as ready for review September 1, 2025 16:54
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025

Your PR no longer requires formatting changes. Thank you for your contribution!

@vchuravy
Copy link
Member Author

@giordano the integration tests are not using EnzymeCore from the repo?

@vchuravy vchuravy force-pushed the vc/ignore_derivatives branch from d4f016f to df5ed81 Compare September 25, 2025 20:57
Support for `ignore_derivatives` was added in Enzyme 0.13.74.
"""
@generated function ignore_derivatives(x::T) where {T}
name = "extern __enzyme_ignore_derivatives." * string(T)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to be generated? I suppose so for having different names for different julia types

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's the crux, we need different names since otherwise LLVM yells at us for having different types.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

figured, in any case lgtm

@wsmoses
Copy link
Member

wsmoses commented Sep 25, 2025

the generate plots/benchmark CI also doesn't like the bump btw:

ERROR: LoadError: Unsatisfiable requirements detected for package EnzymeCore [f151be2c]:
 EnzymeCore [f151be2c] log:
 ├─possible versions are: 0.1.0 - 0.8.13 or uninstalled
 └─restricted to versions 0.8.14 - 0.8 by Enzyme [7da242da] — no versions left
   └─Enzyme [7da242da] log:
     ├─possible versions are: 0.13.81 or uninstalled
     └─Enzyme [7da242da] is fixed to version 0.13.81

@vchuravy vchuravy merged commit 8a2fa2e into main Sep 26, 2025
42 of 44 checks passed
@vchuravy vchuravy deleted the vc/ignore_derivatives branch September 26, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants