Skip to content

avoid a test_throws on Windows#2576

Closed
vchuravy wants to merge 2 commits intomainfrom
vc/test_throws
Closed

avoid a test_throws on Windows#2576
vchuravy wants to merge 2 commits intomainfrom
vc/test_throws

Conversation

@vchuravy
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2025

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic main) to apply these changes.

Click here to view the suggested changes.
diff --git a/test/internal_rules.jl b/test/internal_rules.jl
index 99be4dc..fd04e35 100644
--- a/test/internal_rules.jl
+++ b/test/internal_rules.jl
@@ -315,10 +315,10 @@ end
   b = [3.1 5.6; 13 19]
   db = [1.3 6.5; .13 .19]
 
-  if !Sys.iswindows()
-      # https://github.com/EnzymeAD/Enzyme.jl/issues/2546
-      @test_throws Enzyme.Compiler.EnzymeNoDerivativeError Enzyme.autodiff(set_runtime_activity(Forward), two_blas, Duplicated(a, da), Duplicated(b, b))
-  end
+    if !Sys.iswindows()
+        # https://github.com/EnzymeAD/Enzyme.jl/issues/2546
+        @test_throws Enzyme.Compiler.EnzymeNoDerivativeError Enzyme.autodiff(set_runtime_activity(Forward), two_blas, Duplicated(a, da), Duplicated(b, b))
+    end
 end
 
 @testset "Cholesky" begin

@vchuravy
Copy link
Member Author

Perhaps allows us to run the test farther x-ref #2576 2546

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2025

Benchmark Results

main 98ceaf7... main / 98ceaf7...
basics/overhead 6.17 ± 1.8 ns 4.34 ± 0.01 ns 1.42 ± 0.42
time_to_load 1.27 ± 0.018 s 1.26 ± 0.015 s 1.01 ± 0.019

Benchmark Plots

A plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/17737606855/artifacts/4014102867.

@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.99%. Comparing base (15e1a93) to head (98ceaf7).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2576      +/-   ##
==========================================
- Coverage   75.01%   74.99%   -0.03%     
==========================================
  Files          56       56              
  Lines       17710    17717       +7     
==========================================
+ Hits        13285    13286       +1     
- Misses       4425     4431       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vchuravy vchuravy closed this Sep 17, 2025
@vchuravy vchuravy deleted the vc/test_throws branch September 17, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant