Skip to content

Add optional output_tangent kwarg to test_reverse#2588

Merged
wsmoses merged 1 commit intoEnzymeAD:mainfrom
kshyatt:ksh/output
Sep 18, 2025
Merged

Add optional output_tangent kwarg to test_reverse#2588
wsmoses merged 1 commit intoEnzymeAD:mainfrom
kshyatt:ksh/output

Conversation

@kshyatt
Copy link
Collaborator

@kshyatt kshyatt commented Sep 17, 2025

No description provided.

@github-actions
Copy link
Contributor

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic main) to apply these changes.

Click here to view the suggested changes.
diff --git a/lib/EnzymeTestUtils/src/test_reverse.jl b/lib/EnzymeTestUtils/src/test_reverse.jl
index cf904be..c2c37c1 100644
--- a/lib/EnzymeTestUtils/src/test_reverse.jl
+++ b/lib/EnzymeTestUtils/src/test_reverse.jl
@@ -77,8 +77,9 @@ function test_reverse(
     rtol::Real=1e-9,
     atol::Real=1e-9,
     testset_name=nothing,
-    runtime_activity::Bool=false,
-    output_tangent=nothing)
+        runtime_activity::Bool = false,
+        output_tangent = nothing
+    )
     call_with_captured_kwargs(f, xs...) = f(xs...; fkwargs...)
     if testset_name === nothing
         testset_name = "test_reverse: $f with return activity $ret_activity on $(_string_activity(args))"

Copy link
Member

@wsmoses wsmoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a version bump to EnzymeTestUtils too?

@kshyatt
Copy link
Collaborator Author

kshyatt commented Sep 17, 2025

Done

@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.10%. Comparing base (8476e6c) to head (f3fc0c6).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2588   +/-   ##
=======================================
  Coverage   75.10%   75.10%           
=======================================
  Files          56       56           
  Lines       17724    17724           
=======================================
  Hits        13312    13312           
  Misses       4412     4412           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wsmoses wsmoses merged commit a492fa4 into EnzymeAD:main Sep 18, 2025
34 of 37 checks passed
@kshyatt kshyatt deleted the ksh/output branch September 18, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants