Conversation
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/src/compiler.jl b/src/compiler.jl
index 1afa1a5..c9176a9 100644
--- a/src/compiler.jl
+++ b/src/compiler.jl
@@ -1020,18 +1020,21 @@ end
name = T == Float32 ? name * "f" : name
attrs = if LLVM.version().major <= 15
- LLVM.Attribute[LLVM.EnumAttribute("readnone"), StringAttribute("enzyme_shouldrecompute"),
- EnumAttribute("willreturn"),
- EnumAttribute("nosync"),
- EnumAttribute("nounwind"),
- EnumAttribute("nofree"),
- ]
+ LLVM.Attribute[
+ LLVM.EnumAttribute("readnone"), StringAttribute("enzyme_shouldrecompute"),
+ EnumAttribute("willreturn"),
+ EnumAttribute("nosync"),
+ EnumAttribute("nounwind"),
+ EnumAttribute("nofree"),
+ ]
else
- LLVM.Attribute[EnumAttribute("memory", NoEffects.data), StringAttribute("enzyme_shouldrecompute"),
- EnumAttribute("willreturn"),
- EnumAttribute("nosync"),
- EnumAttribute("nounwind"),
- EnumAttribute("nofree")]
+ LLVM.Attribute[
+ EnumAttribute("memory", NoEffects.data), StringAttribute("enzyme_shouldrecompute"),
+ EnumAttribute("willreturn"),
+ EnumAttribute("nosync"),
+ EnumAttribute("nounwind"),
+ EnumAttribute("nofree"),
+ ]
end
handleCustom(state, custom, k_name, llvmfn, name, attrs)
return
diff --git a/src/llvm/attributes.jl b/src/llvm/attributes.jl
index 32480e2..57d5ade 100644
--- a/src/llvm/attributes.jl
+++ b/src/llvm/attributes.jl
@@ -630,10 +630,10 @@ function annotate!(mod::LLVM.Module)
end
end
end
-
+
for fname in (
- "julia.safepoint",
- )
+ "julia.safepoint",
+ )
if haskey(funcs, fname)
for fn in funcs[fname]
push!(function_attributes(fn), EnumAttribute("nofree")) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2604 +/- ##
==========================================
- Coverage 75.23% 72.47% -2.76%
==========================================
Files 56 55 -1
Lines 17748 17686 -62
==========================================
- Hits 13352 12818 -534
- Misses 4396 4868 +472 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Benchmark Results
Benchmark PlotsA plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/17905678091/artifacts/4068755776. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.