Merged
Conversation
(cherry picked from commit f19b040)
Member
Author
|
Since CI for #2607 will only pick it up from master. Any other ideas instead of just adding deeper and deeper nestings? |
wsmoses
approved these changes
Sep 22, 2025
Contributor
Benchmark Results
Benchmark PlotsA plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/17926021751/artifacts/4075821771. |
Member
|
so my thought on how to do this properly is we should have a function make_zero_internal or something which is the user definable one (or alternatively just make_zero(x, ::Union{Nothing, IdSet})) then the generated function for make_zero(x) has a back edge from all the other internal utilities, and does a recursion through type space until it hits primitives like above, or guaranteed_const types. Types that are active don't need the id check, only duplicated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit f19b040)