Skip to content

fix: MethodError takes in a Tuple#2731

Merged
wsmoses merged 1 commit intomainfrom
avik-pal-patch-1
Nov 3, 2025
Merged

fix: MethodError takes in a Tuple#2731
wsmoses merged 1 commit intomainfrom
avik-pal-patch-1

Conversation

@avik-pal
Copy link
Collaborator

@avik-pal avik-pal commented Nov 3, 2025

No description provided.

@avik-pal avik-pal requested a review from wsmoses November 3, 2025 20:11
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.01%. Comparing base (a7509fb) to head (8e52a71).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/rules/customrules.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2731   +/-   ##
=======================================
  Coverage   70.01%   70.01%           
=======================================
  Files          58       58           
  Lines       19295    19295           
=======================================
  Hits        13510    13510           
  Misses       5785     5785           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Benchmark Results

main 8e52a71... main / 8e52a71...
basics/make_zero/namedtuple 0.053 ± 0.0028 μs 0.0518 ± 0.002 μs 1.02 ± 0.067
basics/make_zero/struct 0.252 ± 0.0045 μs 0.266 ± 0.0038 μs 0.947 ± 0.022
basics/overhead 5.25 ± 0.87 ns 5.26 ± 0.01 ns 0.998 ± 0.17
basics/remake_zero!/namedtuple 0.237 ± 0.0063 μs 0.235 ± 0.0067 μs 1.01 ± 0.039
basics/remake_zero!/struct 0.233 ± 0.0061 μs 0.24 ± 0.0081 μs 0.971 ± 0.041
fold_broadcast/multidim_sum_bcast/1D 10.3 ± 0.21 μs 10.3 ± 0.21 μs 1.01 ± 0.029
fold_broadcast/multidim_sum_bcast/2D 12.1 ± 0.22 μs 12.2 ± 0.22 μs 0.998 ± 0.026
time_to_load 1.23 ± 0.0088 s 1.22 ± 0.0097 s 1 ± 0.011

Benchmark Plots

A plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/19047933181/artifacts/4453955856.

@wsmoses
Copy link
Member

wsmoses commented Nov 3, 2025

also concurrently, @avik-pal would it be worthwhile adding (cpu) lux integration tests to enzyme too?

@avik-pal
Copy link
Collaborator Author

avik-pal commented Nov 3, 2025

@wsmoses
Copy link
Member

wsmoses commented Nov 3, 2025

ah right, they're just consistently greenthat I forgot xD

@wsmoses wsmoses merged commit bc03193 into main Nov 3, 2025
46 of 49 checks passed
@wsmoses wsmoses deleted the avik-pal-patch-1 branch November 3, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants