Skip to content

Implement fix_ptr_lookup for raw fname#2740

Merged
vchuravy merged 1 commit intomainfrom
vc/pointer_decoding
Nov 5, 2025
Merged

Implement fix_ptr_lookup for raw fname#2740
vchuravy merged 1 commit intomainfrom
vc/pointer_decoding

Conversation

@vchuravy
Copy link
Member

@vchuravy vchuravy commented Nov 5, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic main) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/compiler/orcv2.jl b/src/compiler/orcv2.jl
index de3ceb5a..130473a9 100644
--- a/src/compiler/orcv2.jl
+++ b/src/compiler/orcv2.jl
@@ -57,7 +57,7 @@ function fix_ptr_lookup(name)
                 Ref{Ptr{Cvoid}}(C_NULL)
             end
         else
-            arg1 =  parse(Int, arg1)
+            arg1 = parse(Int, arg1)
             hnd_cache = get!(hnd_int_map, arg1) do
                 Ref{Ptr{Cvoid}}(C_NULL)
             end

Base automatically changed from vc+ms/mpi to main November 5, 2025 16:55
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.99%. Comparing base (c009fa5) to head (2d27136).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/compiler/orcv2.jl 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2740      +/-   ##
==========================================
- Coverage   70.01%   69.99%   -0.03%     
==========================================
  Files          58       58              
  Lines       19295    19292       -3     
==========================================
- Hits        13510    13504       -6     
- Misses       5785     5788       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

Benchmark Results

main 2d27136... main / 2d27136...
basics/make_zero/namedtuple 0.0534 ± 0.0071 μs 0.053 ± 0.0027 μs 1.01 ± 0.14
basics/make_zero/struct 0.261 ± 0.0059 μs 0.263 ± 0.0048 μs 0.992 ± 0.029
basics/overhead 4.34 ± 0.01 ns 4.34 ± 0.01 ns 1 ± 0.0033
basics/remake_zero!/namedtuple 0.234 ± 0.0074 μs 0.237 ± 0.0081 μs 0.988 ± 0.046
basics/remake_zero!/struct 0.24 ± 0.0096 μs 0.237 ± 0.013 μs 1.01 ± 0.069
fold_broadcast/multidim_sum_bcast/1D 10.3 ± 0.27 μs 10.3 ± 0.23 μs 1 ± 0.034
fold_broadcast/multidim_sum_bcast/2D 12.3 ± 0.29 μs 12.2 ± 0.26 μs 1.01 ± 0.032
time_to_load 1.25 ± 0.0054 s 1.26 ± 0.0013 s 0.992 ± 0.0044

Benchmark Plots

A plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/19110054514/artifacts/4477161401.

Copy link
Member

@wsmoses wsmoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

@vchuravy vchuravy force-pushed the vc/pointer_decoding branch from 8ba563d to 2d27136 Compare November 5, 2025 17:06
@vchuravy vchuravy merged commit 97dbf1b into main Nov 5, 2025
48 of 52 checks passed
@vchuravy vchuravy deleted the vc/pointer_decoding branch November 5, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants