Conversation
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/src/rules/llvmrules.jl b/src/rules/llvmrules.jl
index b48c46aa..7b642c89 100644
--- a/src/rules/llvmrules.jl
+++ b/src/rules/llvmrules.jl
@@ -1349,10 +1349,10 @@ end
newvals = API.CValueType[API.VT_Shadow, API.VT_Primal, API.VT_Shadow, API.VT_None]
newops = LLVM.Value[
- shadowh,
- new_from_original(gutils, origkey),
- shadowval,
- LLVM.null(value_type(originserted)),
+ shadowh,
+ new_from_original(gutils, origkey),
+ shadowval,
+ LLVM.null(value_type(originserted)),
]
shadowres = batch_call_same_with_inverted_arg_if_active!(B, gutils, orig, newops, newvals, false;
diff --git a/test/rules/internal_rules.jl b/test/rules/internal_rules.jl
index e33ae6b4..41808f78 100644
--- a/test/rules/internal_rules.jl
+++ b/test/rules/internal_rules.jl
@@ -220,7 +220,7 @@ end
end
end
@testset "reverse" begin
- @testset for RT in (Const, Active,), Tx in (Const, Duplicated,)
+ @testset for RT in (Const, Active), Tx in (Const, Duplicated)
x = [4.0 3.0; 2.0 1.0]
test_reverse(LinearAlgebra.det, RT, (x, Tx))
|
Contributor
Benchmark Results
Benchmark PlotsA plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/19204858457/artifacts/4510817769. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2756 +/- ##
==========================================
- Coverage 70.31% 70.30% -0.02%
==========================================
Files 58 58
Lines 19390 19391 +1
==========================================
- Hits 13635 13633 -2
- Misses 5755 5758 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.