Skip to content

Fix eqtable put#2756

Merged
wsmoses merged 2 commits intomainfrom
eqp
Nov 9, 2025
Merged

Fix eqtable put#2756
wsmoses merged 2 commits intomainfrom
eqp

Conversation

@wsmoses
Copy link
Member

@wsmoses wsmoses commented Nov 9, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2025

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic main) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/rules/llvmrules.jl b/src/rules/llvmrules.jl
index b48c46aa..7b642c89 100644
--- a/src/rules/llvmrules.jl
+++ b/src/rules/llvmrules.jl
@@ -1349,10 +1349,10 @@ end
     newvals = API.CValueType[API.VT_Shadow, API.VT_Primal, API.VT_Shadow, API.VT_None]
 
     newops = LLVM.Value[
-      shadowh,
-      new_from_original(gutils, origkey),
-      shadowval,
-      LLVM.null(value_type(originserted)),
+        shadowh,
+        new_from_original(gutils, origkey),
+        shadowval,
+        LLVM.null(value_type(originserted)),
     ]
 
     shadowres = batch_call_same_with_inverted_arg_if_active!(B, gutils, orig, newops, newvals, false;
diff --git a/test/rules/internal_rules.jl b/test/rules/internal_rules.jl
index e33ae6b4..41808f78 100644
--- a/test/rules/internal_rules.jl
+++ b/test/rules/internal_rules.jl
@@ -220,7 +220,7 @@ end
         end
     end
     @testset "reverse" begin
-        @testset for RT in (Const, Active,), Tx in (Const, Duplicated,)
+        @testset for RT in (Const, Active), Tx in (Const, Duplicated)
             x = [4.0 3.0; 2.0 1.0]
             test_reverse(LinearAlgebra.det, RT, (x, Tx))
 

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2025

Benchmark Results

main af326d4... main / af326d4...
basics/make_zero/namedtuple 0.0556 ± 0.0021 μs 0.0549 ± 0.0021 μs 1.01 ± 0.055
basics/make_zero/struct 0.262 ± 0.0058 μs 0.257 ± 0.0074 μs 1.02 ± 0.037
basics/overhead 4.34 ± 0.01 ns 5.25 ± 0.92 ns 0.826 ± 0.15
basics/remake_zero!/namedtuple 0.238 ± 0.011 μs 0.245 ± 0.011 μs 0.97 ± 0.061
basics/remake_zero!/struct 0.233 ± 0.01 μs 0.234 ± 0.01 μs 0.993 ± 0.061
fold_broadcast/multidim_sum_bcast/1D 10.4 ± 1.9 μs 10.3 ± 0.26 μs 1.01 ± 0.19
fold_broadcast/multidim_sum_bcast/2D 12.2 ± 0.29 μs 12.1 ± 0.31 μs 1.01 ± 0.035
time_to_load 1.31 ± 0.021 s 1.3 ± 0.0065 s 1 ± 0.017

Benchmark Plots

A plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/19204858457/artifacts/4510817769.

@wsmoses wsmoses merged commit 5be838f into main Nov 9, 2025
41 of 48 checks passed
@wsmoses wsmoses deleted the eqp branch November 9, 2025 08:38
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.30%. Comparing base (b42dcf0) to head (af326d4).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/rules/llvmrules.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2756      +/-   ##
==========================================
- Coverage   70.31%   70.30%   -0.02%     
==========================================
  Files          58       58              
  Lines       19390    19391       +1     
==========================================
- Hits        13635    13633       -2     
- Misses       5755     5758       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant