Skip to content

Fix ABI mismatch#2776

Merged
wsmoses merged 2 commits intomainfrom
amm
Nov 13, 2025
Merged

Fix ABI mismatch#2776
wsmoses merged 2 commits intomainfrom
amm

Conversation

@wsmoses
Copy link
Member

@wsmoses wsmoses commented Nov 13, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

Benchmark Results

main c932f8e... main / c932f8e...
basics/make_zero/namedtuple 0.0552 ± 0.0028 μs 0.0538 ± 0.0025 μs 1.03 ± 0.069
basics/make_zero/struct 0.257 ± 0.0074 μs 0.255 ± 0.0076 μs 1.01 ± 0.042
basics/overhead 4.34 ± 0.91 ns 4.34 ± 0.01 ns 1 ± 0.21
basics/remake_zero!/namedtuple 0.242 ± 0.011 μs 0.242 ± 0.0084 μs 1 ± 0.056
basics/remake_zero!/struct 0.235 ± 0.012 μs 0.233 ± 0.0098 μs 1.01 ± 0.068
fold_broadcast/multidim_sum_bcast/1D 10.3 ± 0.26 μs 10.5 ± 1.7 μs 0.985 ± 0.16
fold_broadcast/multidim_sum_bcast/2D 12.1 ± 0.3 μs 12.1 ± 0.3 μs 1 ± 0.035
time_to_load 1.29 ± 0.0074 s 1.27 ± 0.031 s 1.01 ± 0.026

Benchmark Plots

A plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/19342762514/artifacts/4560276837.

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.94%. Comparing base (f7ec291) to head (c932f8e).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/rules/llvmrules.jl 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2776      +/-   ##
==========================================
- Coverage   68.96%   68.94%   -0.02%     
==========================================
  Files          58       58              
  Lines       19961    19961              
==========================================
- Hits        13766    13763       -3     
- Misses       6195     6198       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic main) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/rules/llvmrules.jl b/src/rules/llvmrules.jl
index 14829bc8..f42c6a3f 100644
--- a/src/rules/llvmrules.jl
+++ b/src/rules/llvmrules.jl
@@ -1590,8 +1590,8 @@ end
             if get_runtime_activity(gutils) && endB === nothing
                 cond = icmp!(B, LLVM.API.LLVMIntNE, fval, args[1])
 
-	        currentBlock = Base.position(B)
-        	ogname = LLVM.name(currentBlock)
+                currentBlock = Base.position(B)
+                ogname = LLVM.name(currentBlock)
 
                 nextB = add_reverse_block!(gutils, currentBlock, ogname*"_active")
 
@@ -1661,9 +1661,9 @@ end
 
             if get_runtime_activity(gutils)
                 cond = icmp!(B, LLVM.API.LLVMIntNE, fval, anti)
-        
-		currentBlock = Base.position(B)
-		ogname = LLVM.name(currentBlock)
+
+                currentBlock = Base.position(B)
+                ogname = LLVM.name(currentBlock)
 
                 nextB = add_reverse_block!(gutils, currentBlock, ogname*"_active")
 

@wsmoses wsmoses merged commit bf4088f into main Nov 13, 2025
44 of 52 checks passed
@wsmoses wsmoses deleted the amm branch November 13, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant