[CI] Dynamically generate list of packages to test #2785
+43
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
force-pushed
the
mg/dynamic-integration
branch
7 times, most recently
from
b7447b2 to
cd5d8e6
Compare
giordano
force-pushed
the
mg/dynamic-integration
branch
from
cd5d8e6 to
3ce300e
Compare
giordano
commented
Nov 14, 2025
| shell: julia --color=yes {0} | ||
| run: | | ||
| all_pkgs = readdir("test/integration") | ||
| filtered_pkgs = all_pkgs |
Member
Author
There was a problem hiding this comment.
Ok, this is now working, but here we need to define a criterion for filtering the packages, probably something like what we do in Yggdrasil (but in Yggdrasil we only allow for squash-merge, which makes diff-ing on main easier)
Member
|
I would actually recommend not doing this, running the integration tests for all enzyme code has caught [at least for me] many bugs already |
Member
Author
|
As I said in #2784 (comment), the idea is to do this only when integration only tests are changed. It doesn't make much sense to run all the integration tests when only one new is added. |
Member
|
ah got it, sorry missed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very incomplete, but this is an initial proof-of-concept of #2784 (comment), still need to do the filtering.