Skip to content

Don't mark math fns as nounwind, just willreturn#2807

Merged
wsmoses merged 3 commits intomainfrom
nounwind
Nov 24, 2025
Merged

Don't mark math fns as nounwind, just willreturn#2807
wsmoses merged 3 commits intomainfrom
nounwind

Conversation

@wsmoses
Copy link
Member

@wsmoses wsmoses commented Nov 24, 2025

No description provided.

@github-actions
Copy link
Contributor

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic main) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/compiler.jl b/src/compiler.jl
index 153c42cb..9f6dd733 100644
--- a/src/compiler.jl
+++ b/src/compiler.jl
@@ -1056,13 +1056,13 @@ end
     attrs = if LLVM.version().major <= 15
         LLVM.Attribute[LLVM.EnumAttribute("readnone"), StringAttribute("enzyme_shouldrecompute"),
                     EnumAttribute("willreturn"),
-                    EnumAttribute("nosync"),
+            EnumAttribute("nosync"),
                     EnumAttribute("nofree"),
 		      ]
     else
         LLVM.Attribute[EnumAttribute("memory", NoEffects.data), StringAttribute("enzyme_shouldrecompute"),
                     EnumAttribute("willreturn"),
-                    EnumAttribute("nosync"),
+            EnumAttribute("nosync"),
 		    EnumAttribute("nofree")]
     end
     handleCustom(state, custom, k_name, llvmfn, name, attrs)

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.79%. Comparing base (f9dd728) to head (0dc2660).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2807      +/-   ##
==========================================
- Coverage   67.81%   67.79%   -0.03%     
==========================================
  Files          58       58              
  Lines       20717    20723       +6     
==========================================
- Hits        14050    14049       -1     
- Misses       6667     6674       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

Benchmark Results

main 0dc2660... main / 0dc2660...
basics/make_zero/namedtuple 0.0522 ± 0.0023 μs 0.0527 ± 0.0026 μs 0.991 ± 0.065
basics/make_zero/struct 0.255 ± 0.0059 μs 0.259 ± 0.0057 μs 0.984 ± 0.031
basics/overhead 4.03 ± 0.051 ns 5.26 ± 0.01 ns 0.766 ± 0.0098
basics/remake_zero!/namedtuple 0.241 ± 0.0076 μs 0.236 ± 0.0086 μs 1.02 ± 0.049
basics/remake_zero!/struct 0.233 ± 0.009 μs 0.237 ± 0.0085 μs 0.98 ± 0.052
fold_broadcast/multidim_sum_bcast/1D 10.3 ± 0.22 μs 10.3 ± 0.47 μs 0.993 ± 0.05
fold_broadcast/multidim_sum_bcast/2D 12.1 ± 0.26 μs 12.1 ± 0.26 μs 0.999 ± 0.03
time_to_load 1.25 ± 0.017 s 1.26 ± 0.034 s 0.989 ± 0.03

Benchmark Plots

A plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/19643004634/artifacts/4663546068.

@wsmoses wsmoses merged commit 30e0519 into main Nov 24, 2025
52 of 54 checks passed
@wsmoses wsmoses deleted the nounwind branch November 24, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant