Skip to content

Fix: Vararg{<:AbstractFloat} -> Vararg{AbstractFloat}#2809

Merged
wsmoses merged 1 commit intoEnzymeAD:mainfrom
devmotion:dmw/vararg
Nov 24, 2025
Merged

Fix: Vararg{<:AbstractFloat} -> Vararg{AbstractFloat}#2809
wsmoses merged 1 commit intoEnzymeAD:mainfrom
devmotion:dmw/vararg

Conversation

@devmotion
Copy link
Contributor

@devmotion devmotion commented Nov 24, 2025

Fixes https://github.com/EnzymeAD/Enzyme.jl/actions/runs/19623837183/job/56188979383#step:12:218:

┌ Enzyme
│  WARNING: Wrapping `Vararg` directly in UnionAll is deprecated (wrap the tuple instead).
│  You may need to write `f(x::Vararg{T})` rather than `f(x::Vararg{<:T})` or `f(x::Vararg{T}) where T` instead of `f(x::Vararg{T} where T)`.
│  To make this warning an error, and hence obtain a stack trace, use `julia --depwarn=error`.
└

@wsmoses
Copy link
Member

wsmoses commented Nov 24, 2025

oh thats where it's been coming from?

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.81%. Comparing base (f9dd728) to head (7a41503).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2809      +/-   ##
==========================================
- Coverage   67.81%   67.81%   -0.01%     
==========================================
  Files          58       58              
  Lines       20717    20717              
==========================================
- Hits        14050    14049       -1     
- Misses       6667     6668       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@devmotion
Copy link
Contributor Author

Yes. CI seems to confirm it, I can't see these warnings in the logs anymore.

@wsmoses wsmoses merged commit a2c161e into EnzymeAD:main Nov 24, 2025
48 of 49 checks passed
@devmotion devmotion deleted the dmw/vararg branch November 24, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants