Skip to content

fix memory leak for hessian calcs, remove some warnings #2714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeffpollock9 wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −3
Open

fix memory leak for hessian calcs, remove some warnings #2714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
310e244
fix memory leak
jeffpollock9 Feb 27, 2026
05b6cb6
fix warnings
jeffpollock9 Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion enzyme/Enzyme/CallDerivatives.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4129,6 +4129,7 @@ bool AdjointGenerator::handleKnownCallDerivatives(
return true;
}
eraseIfUnused(call);
return true;
}
auto callval = call.getCalledOperand();

Expand Down Expand Up @@ -4216,7 +4217,11 @@ bool AdjointGenerator::handleKnownCallDerivatives(
}

// TODO HANDLE FREE
llvm::errs() << "freeing without malloc " << *val << "\n";
// Suppress warning for common safe cases (phi nodes, loads) that are
// conservatively handled but can't be statically matched to allocations
if (!isa<PHINode>(val) && !isa<LoadInst>(val)) {
llvm::errs() << "freeing without malloc " << *val << "\n";
}
eraseIfUnused(call, /*erase*/ true, /*check*/ false);
return true;
}
Expand Down
4 changes: 2 additions & 2 deletions enzyme/Enzyme/TypeAnalysis/TypeAnalysis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1520,8 +1520,8 @@ void TypeAnalyzer::considerTBAA() {
} else if (call->getType()->isPointerTy()) {
updateAnalysis(call, vdptr.Only(-1, call), call);
} else {
llvm::errs() << " unknown tbaa call instruction user inst: " << I
<< " vdptr: " << vdptr.str() << "\n";
// llvm::errs() << " unknown tbaa call instruction user inst: " << I
// << " vdptr: " << vdptr.str() << "\n";
}
} else if (auto SI = dyn_cast<StoreInst>(&I)) {
auto StoreSize =
Expand Down