Add rev mode support for memref.alloca_scope#2814
Open
vimarsh6739 wants to merge 11 commits into
Open
Conversation
ad79e42 to
1f42ce5
Compare
Collaborator
|
For %dbuf's lifetime, I feel like there are two ways to fix it:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opening the alloca_scope PR in the repo
I dont think this will work if the
alloca_scopehas amemref.allocainside it (caching it will be unsafe across the 2 alloca_scope ops that are emitted)Something like this will fail
The primal is basically
Reverse Mode should give us
We want this to lower to something like this (need to discuss what the caching should look like, since I dont think we can just push the memref to the cache here)
The issue is that the cache push/pop will not be valid across the 2 alloca_scopes here