Preserve noinline/debug callsite info when lowering Enzyme autodiff calls#2829
Draft
Copilot wants to merge 2 commits into
Draft
Preserve noinline/debug callsite info when lowering Enzyme autodiff calls#2829Copilot wants to merge 2 commits into
noinline/debug callsite info when lowering Enzyme autodiff calls#2829Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/EnzymeAD/Enzyme/sessions/1cc6cbf7-94a6-48de-8348-912cce695620 Co-authored-by: wsmoses <1260124+wsmoses@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix enzyme pass dropping noinline attribute
Preserve May 16, 2026
noinline/debug callsite info when lowering Enzyme autodiff calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enzyme was dropping callsite
noinlinemetadata during lowering, which made rewritten calls inlineable and could trigger LLVM verifier failures (inlinable function call ... must have a !dbg location). This PR preserves the relevant callsite properties on replacement calls.Root cause addressed
HandleAutoDiffcreated a new derivative call but did not carry forward callsitenoinline.__enzyme_call_inactivelowering created replacement calls without propagating debug location andnoinline.Code changes
Enzyme/Enzyme.cppHandleAutoDiff(...), propagateAttribute::NoInlinefrom the original call to the generated derivative call.InactiveCallsloop), propagate both:DebugLoc(setDebugLoc(CI->getDebugLoc()))Attribute::NoInline(if present on the original call).Regression coverage
test/Enzyme/ReverseMode/undefalloc.ll__enzyme_autodiffcallsite asnoinline.@diffefremainsnoinline.